feat: add favicon #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this uses https://realfavicongenerator.net/ in order to generate the icons in the appropriate sizes and formats. reduces the network traffic by serving a smaller favicon, and also accounts for the different formats different browsers use.
using oxipng -o 4 --strip safe --alpha *.png
|
hi @jathek, thanks for this PR !! favicons are browser dependent 🤷♂️, so I made some changes to account for this thank you again ! |
|
Sounds good! That site is great, definitely bookmarking. I do have one comment. The safari-pinned-tab.svg is just a blank circle. I think maybe you should click the radio to convert to a monochrome icon, and tweak the color? Then it comes out looking like this instead: The stock vite.svg never showed up for me when I accessed the unbalanced I have currently installed. It only appeared locally when running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies index.html so that
unbalance-logo.pngis used as the favicon for the page.Before & after:
It works for me locally, and I think it should work in the final plugin as well, because the link href does seem to get converted by vite into same paths as everything else:
