💚 bash5 tests

jcaillon · Feb 1, 2025 · e250900 · e250900
1 parent fed1fea
commit e250900
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 14 deletions.
diff --git a/.github/workflows/self-test.yaml b/.github/workflows/self-test.yaml
@@ -41,13 +41,13 @@ jobs:
           chmod +x valet
           ./valet self test -C
 
-      # # Runs tests with bash 5
-      # - name: Run valet self test on bash5
-      #   run: |
-      #     chmod +x valet
-      #     docker run --rm \
-      #       -v $PWD:/app \
-      #       -w /app \
-      #       -e VALET_CONFIG_ENABLE_COLORS=true \
-      #       noyacode/minideb-bash5.0 \
-      #       ./valet self test -C
+      # Runs tests with bash 5
+      - name: Run valet self test on bash5
+        run: |
+          chmod +x valet
+          docker run --rm \
+            -v $PWD:/app \
+            -w /app \
+            -e VALET_CONFIG_ENABLE_COLORS=true \
+            noyacode/minideb-bash5.0 \
+            ./valet self test -C
diff --git a/commands.d/self-test-utils b/commands.d/self-test-utils
@@ -117,7 +117,7 @@ function selfTestUtils_compareWithApproved() {
   if ${command} 1>&2; then
     log::success "→ test suite has passed."
     if [[ -f "${receivedFile}" ]]; then
-      rm -f "${receivedFile}" 1>/dev/null
+      rm -f "${receivedFile}" 1>/dev/null || :
     fi
     return 0
   else
@@ -133,7 +133,7 @@ function selfTestUtils_compareWithApproved() {
       chmod "${GLOBAL_TEST_REPORT_FILE_MODE}" "${approvedFile}"
     fi
     if [[ -f "${receivedFile}" ]]; then
-      rm -f "${receivedFile}" 1>/dev/null
+      rm -f "${receivedFile}" 1>/dev/null || :
     fi
   else
     cp -f "${receivedFileToCopy}" "${receivedFile}"

diff --git a/commands.d/self-test.sh b/commands.d/self-test.sh
@@ -535,7 +535,7 @@ function selfTest_runSingleTest() {
 
   # reset the temporary location (to have consistency when using fs::createTempDirectory for example)
   if [[ -d ${GLOBAL_TEST_BASE_TEMPORARY_DIRECTORY} ]]; then
-    rm -Rf "${GLOBAL_TEST_BASE_TEMPORARY_DIRECTORY}"
+    rm -Rf "${GLOBAL_TEST_BASE_TEMPORARY_DIRECTORY}" || :
   fi
   fs::setupTempFileGlobalVariable
   fs::cleanTempFiles

diff --git a/libraries.d/core b/libraries.d/core
@@ -1580,7 +1580,7 @@ function core::reloadUserCommands() {
 # ```
 function core::deleteUserCommands() {
   core::getUserDirectory
-  rm -f "${RETURNED_VALUE}/commands"
+  rm -f "${RETURNED_VALUE}/commands" || :
 }
 
 # ## core::getVersion

diff --git a/libraries.d/lib-bash b/libraries.d/lib-bash
@@ -113,6 +113,7 @@ function bash::runInParallel() {
         if [[ -z ${pid} ]]; then
           continue
         fi
+        log::warning "pid=${pid}, xx=${jobIndexFromPid[${pid}]:-x}, jobIndexFromPid: ${!jobIndexFromPid[*]}, , jobIndexFromPid: ${jobIndexFromPid[*]}"
         jobIndex="${jobIndexFromPid[${pid}]}"
         jobName="${jobNames[jobIndex]}"