Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly overhaul the ApnsClientMetricsListener interface #1046

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

jchambers
Copy link
Owner

This (in my opinion) greatly improves the ApnsClientMetricsListener interface at the cost of making a bunch of breaking changes. The key changes are:

  1. We no longer issue opaque "notification IDs" to metrics listeners, but instead provide "send notification" durations where appropriate
  2. We now consolidate accepted/rejected handlers into a single "acknowledged" handler that has access to the full notification response
  3. The Micrometer implementation is now much, much more sensibly constructed; when I first built it, I had never really used Micrometer before and was mostly guessing at how it worked. Now that I have significant direct experience with it, I can offer a much more sensible and ergonomic design.

Feedback on all of this is very welcome.

@jhonynet
Copy link

Hi Jon! do you have any plans to release this soon?

@jchambers
Copy link
Owner Author

No specific plan other than "next." With WWDC happening, though, I expect there will be at least some changes that demand a more immediate response, and that's likely to prompt a more concentrated burst of activity on this project from me.

@jchambers jchambers force-pushed the revised_metric_listener branch from ff1ef36 to 8b36065 Compare July 6, 2024 16:19
@jchambers jchambers merged commit c9f92fb into main Jul 6, 2024
64 checks passed
@jchambers jchambers deleted the revised_metric_listener branch July 6, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants