Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made resconf compatible with Windows #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Made resconf compatible with Windows #5

wants to merge 1 commit into from

Conversation

LinFor
Copy link

@LinFor LinFor commented Feb 13, 2020

Just added second implementation of rescon module with conditional compilation by target OS.

@jcrowgey
Copy link
Owner

Thanks for sending this. Do you mind fixing the missing newlines on some of these files?

@LinFor
Copy link
Author

LinFor commented Feb 14, 2020

Hello. Not sure what exactly you meant, but now all the files contain a trailing line feed.
I'm newbie in rust and don't know style conventions. I'm using your project as a good starting point, fell free to correct me.

@jcrowgey
Copy link
Owner

Hello. Not sure what exactly you meant, but now all the files contain a trailing line feed.
I'm newbie in rust and don't know style conventions. I'm using your project as a good starting point, fell free to correct me.

For reference on newlines, see 1. If you don't do this, standard tools like diff generate awkward messages:

$ diff <(echo "hi") <(echo -n "hi")
1c1
< hi
---
> hi
\ No newline at end of file

It's that awkward "\ No newline at end of mile" message which github was translating into the red arrow
on your diff. Anyway, thanks for correcting it. :)

I know next to nothing about Windows and how it does networking. Does lud actually work on windows after this change? I'm curious.

Finally, let's leave in Cargo.lock (for now), as per 2. After that, this looks ready to merge. And thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants