Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respects min argument for wait_random_exponential #425

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

yxtay
Copy link
Contributor

@yxtay yxtay commented Dec 18, 2023

Summary

Respects min argument for wait_random_exponential

  • currently, min argument only affects computing the high range of the uniform sampling
  • min does not affect the low range of the uniform sampling, hence the sampled wait may be lower than min specified
  • This PR fixes the issue, which I believe is unexpected

Tests

pytest tests/test_tenacity.py::TestWaitConditions::test_wait_random_exponential

jd
jd previously approved these changes Dec 18, 2023
@mergify mergify bot dismissed jd’s stale review December 18, 2023 08:41

Pull request has been modified.

@yxtay yxtay requested a review from jd December 18, 2023 08:44
jd
jd previously approved these changes Mar 2, 2024
@mergify mergify bot dismissed jd’s stale review March 2, 2024 09:19

Pull request has been modified.

@Dheavyman
Copy link

Any update on merging this please?

jd
jd previously approved these changes Jul 26, 2024
@mergify mergify bot dismissed jd’s stale review July 27, 2024 13:22

Pull request has been modified.

@mergify mergify bot merged commit a662bbb into jd:main Jul 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants