feat: Chinese(zh-Hans) translation to fastlane metadata #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi title.txt is the app title/name shown on fdroid or google play, please make sure it is consistent with the name of the app from #13 |
# Conflicts: # fastlane/metadata/android/zh-Hans/title.txt
|
Thanks for your careful review. A new PR will replace this bad PRThanks for your careful review. A new PR will replace this bad PR |
|
ops. It seems that I don't need to open a new one |
|
Hi |
|
thanks for contributing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supplement for #13. Sorry to leak the part of them. Language tested on my phone with LineageOS 20. But I can not test the fastlane metadata.
I see otphelper/fastlane/metadata/android/en-US/images/phoneScreenshots and otphelper/fastlane/metadata/android/de/images/phoneScreenshots. So I think I should add 2 images. However, you said you will do some changes to the component. Thus, I do not upload the images. If needed, I am happy to help.