Add zh-tw unit tests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked and pushed a fix that will probably fix the issue please merge the main branch to re-run your tests thanks you |
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Signed-off-by: Still Hsu <[email protected]>
Still34
force-pushed
the
features/zh-tw-support-1
branch
from
cf7c8e4
to
b8bb10f
Compare
|
thanks for contributing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds unit tests for zh-tw cases. However, this PR should not be merged yet as two of the banking tests currently do not pass. The fault currently lies within the regex used to capture the OTP code, where if the code is not surrounded by whitespace, the code is not captured.