Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Italian traduction #35

Merged
merged 6 commits into from
Nov 13, 2023
Merged

Italian traduction #35

merged 6 commits into from
Nov 13, 2023

Conversation

lollo03
Copy link
Contributor

@lollo03 lollo03 commented Nov 13, 2023

No description provided.

@jd1378
Copy link
Owner

jd1378 commented Nov 13, 2023

hi
if you want to make the PR complete do the following, or I can merge and do it myself later (drop a comment if you prefer me to do it):

please move <string name="it" translatable="false">Italiano</string> to values/strings.xml and remove all translatable="false" entries from values-it/strings.xml

add your language to the language selection view model

@jd1378 jd1378 merged commit f7d89de into jd1378:main Nov 13, 2023
1 check passed
@jd1378
Copy link
Owner

jd1378 commented Nov 13, 2023

thanks for contributing

@lollo03 lollo03 deleted the patch-2 branch November 13, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lollo03 @jd1378