Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeExtractor.kt #72

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Update CodeExtractor.kt #72

merged 3 commits into from
Apr 6, 2024

Conversation

nvllz
Copy link
Contributor

@nvllz nvllz commented Apr 5, 2024

No description provided.

@jd1378
Copy link
Owner

jd1378 commented Apr 6, 2024

Hi
thanks for contributing
please add actual messages that contain these sensitive keywords in unit tests
and restrict your sensitive keywords regex like previous sensitive keywords if they do not require them to be matched inside a word. for example: "\\bOTP\\W"

@nvllz
Copy link
Contributor Author

nvllz commented Apr 6, 2024

Hi @jd1378, should be fine now. Keywords are case-insensitive (OTP == otp), right?

@jd1378
Copy link
Owner

jd1378 commented Apr 6, 2024

Hi
Yes, the regex has case insensitive flag set
Thanks for the changes

@jd1378 jd1378 merged commit 9d33921 into jd1378:main Apr 6, 2024
1 check passed
@jd1378
Copy link
Owner

jd1378 commented Apr 6, 2024

released in 1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants