-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for specifying CA certificates (required for some HTTPS proxies #303) #312
base: master
Are you sure you want to change the base?
Conversation
…depoix#303. To fetch HTTPS pages, you will need to download and install the a certificate in your HTTP client. In this case, we need to pass to requests the verify paramenter which sets the path to certificate.
very useful, @danielsanmartin - do you have some sort of a walkthrough, on how exactly I need to install those ca certificates and specify them here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danielsanmartin 👋
Thank you very much for your contribution! 😊
Just to make sure I am not missing something: this just allows you to specify/override the CA certificate used, which is required by Zyte to use their https proxies. This might potentially also be the case for other proxy services, but it is fairly provider specific. Correct?
I am happy to merge this (with some slight adjustments mentioned in the comments), I just want to make very clear that this does not solve #303 and it does not avoid IP bans, it only allows you to use Zyte as a workaround to being IP banned, but even your proxies IP can still be banned in the future by YouTube. (I just want to highlight this, as the title of this PR might raise some false expectations and a lot of people are currently following #303. I have updated the title of this PR to avoid false expectations.)
Also, it would be great if you could mention this param in the README. I think you can just add it to the Proxy section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. I agree with all the proposed developments.
Hi. I already did the requested changes. |
To fetch HTTPS pages, you will need to download and install the a certificate in your HTTP client. In this case, we need to pass to requests the verify paramenter which sets the path to certificate.