Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boostcamp and Shazam as Easy #1886

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Conversation

Szythers
Copy link
Contributor

@Szythers Szythers commented Nov 17, 2023

Added sections for Boostcamp and Shazam, hopefully I did it right this is my first time using Github and I just copy and pasted other easy entries and replaced the data.

Added sections for Boostcamp and Shazam
Copy link
Contributor

@Kefaku Kefaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always prefer having comments to guide the user, even if there isn't much additional information like for Boostcamp.
At least Shazam should have notes giving additional information like accounts beeing deleted within 30 days and Shazam possibly retaining some data.

I therefore added some notes as suggested changes.

_data/sites.json Show resolved Hide resolved
_data/sites.json Show resolved Hide resolved
Szythers and others added 2 commits November 18, 2023 17:07
@tupaschoal tupaschoal merged commit 8db194e into jdm-contrib:master Nov 19, 2023
4 checks passed
@tupaschoal
Copy link
Member

Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants