Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created JS code to search for dead links in the README.md and README-etc.md #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheeDorf
Copy link

@TheeDorf TheeDorf commented Aug 1, 2023

Edit: removed script

@jdorfman
Copy link
Owner

jdorfman commented Aug 1, 2023

@TheeDorf, thanks for your PR. I just don't know what is happening here:

Image 2023-07-31 at 8 52 08 PM png

If you are writing a script to find dead links, why am I seeing links that are ok? It should just be a list of links that need to be removed. E.g.

- https://api.foo.com/v4/latest/bar
- https://api.foo.com/v4/latest/baz

Thanks!

@jdorfman jdorfman self-assigned this Aug 1, 2023
@jdorfman
Copy link
Owner

jdorfman commented Aug 1, 2023

Check out #218

@TheeDorf
Copy link
Author

TheeDorf commented Aug 1, 2023

@jdorfman It seems the code is not reading some of the sites correctly. It should be only showing broken links that are coming back with a 404/502. I will debug this and send it back over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants