Added rf12_set_sender_id to allow senderID to be switched without having #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to rf12_initialise again fixed rf12_send_start to allow destId to be set correctly on sending
JohnOH
reviewed
May 21, 2023
| @@ -8,8 +8,9 @@ | |||
|
|
|||
| // Modify the RF12 driver in such a way that it can inter-operate with RFM69 | |||
| // modules running in "native" mode. This affects packet layout and some more. | |||
| #define RF12_COMPAT 0 | |||
| #define RF12_COMPAT 1 | |||
There was a problem hiding this comment.
Native mode on the RFM69 is not the default mode of operation.
JohnOH
reviewed
May 21, 2023
| @@ -14,6 +14,11 @@ | |||
| #endif | |||
|
|
|||
| #if RF12_COMPAT | |||
| /* | |||
JohnOH
reviewed
May 21, 2023
| @@ -497,7 +502,8 @@ void rf12_sendStart (uint8_t hdr) { | |||
| uint8_t parity = group ^ (group << 4); | |||
| parity = (parity ^ (parity << 2)) & 0xC0; | |||
| // the lower 6 bits are the destination, or zer of broadcasting | |||
| rf12_dst = parity | (hdr & RF12_HDR_DST ? hdr & RF12_HDR_MASK : 0); | |||
| //rf12_dst = parity | (hdr & RF12_HDR_DST ? hdr & RF12_HDR_MASK : 0); | |||
| rf12_dst = parity | ( hdr & RF12_HDR_MASK ); | |||
There was a problem hiding this comment.
I don't grasp what this change does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to rf12_initialise again
fixed rf12_send_start to allow destId to be set correctly on sending