rewrite include to only be a single line #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-hykin
approved these changes
Jul 24, 2019
|
Running the tests it looks like I forgot the scope These should either be fixed or documented as changes. |
|
We should probably keep the originals for now |
|
As soon as the scopes are back I'll re-merge this. |
|
Yeah, I'm working on a fix with the correct scopes and support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the meta_preprocessor_include pattern from a range to a simple match.
Motivation
Standard Conformance
[cpp.include] Specifies that a header path cannot contain a newline. The original pattern was over matching by being a range.
Additionally, paragraph 4 permits a macro to be used as a the include path. This currently has no highlight for such contructs.
Avoiding repaints
If the
#includedirective is actively being typed, and as a result is incomplete/ The current grammar would often cause repaints of large swaths of the document. This is not only slow and unnecessary but often annoying.Supporting compiler extensions
See textmate/c.tmbundle#66