Add commits to site.github #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
reviewed
Feb 22, 2017
| @@ -98,6 +98,10 @@ def releases | |||
| memoize_value :@releases, Value.new(proc { |c| c.releases(nwo) }) | |||
| end | |||
|
|
|||
| def commits | |||
| memoize_value :@commits, Value.new(proc { |c| c.commits(nwo) }) | |||
There was a problem hiding this comment.
My only concern here is that we limit this to something reasonable like 50 or 100. I believe we may have auto_paginate on which would mean if you have 200,000 commits, we'd try to grab all of them. 😳
There was a problem hiding this comment.
Yeaaa... 200,000 commits are definitely not needed. Are you able to set auto_paginate to false for a specific endpoint?
There was a problem hiding this comment.
We'd have to turn it off for the client while this call is made. Something like: octokit/octokit.rb#554 (comment)
There was a problem hiding this comment.
Okay I see what'll need to happen, but unfortunately I'm not proficient in Ruby. How would I go about implementing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to propose that commits be added to site.github. The main reason for this would be for display your commit history on your generated site.
Currently I am building an internal documentation site and thought it would be great to have a recent activity feed or history feed.