-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust color contrast to comply with WCAG 2.0 AA #500
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting this pull request @mgifford. Also, I'd prefer having lowercase characters for the colors' hex values... |
@ashmaroli If you are revisiting the social media icons, just make sure that they have accessibility plugged in. SVG files need titles, or if they are decorative need to be clearly hidden. I don't know how to do what you are asking for. I wanted to have 2 separate pull requests. No idea why they got merged together. Couldn't find an easy way to submit a new one. Not sure how to "defer changes to the social icons" so at the moment I'll leave them as is. |
jekyll/minima#500 only effects on the classic theme. It's now recommended to use browsers' reader views instead of forcing the solarized skin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate you updating things to WCAG 2.0 AA. Would you be able to provide before and after screenshots and fix that small typo I found?
@mgifford There seems to be a merge conflict due to recent changes to the Additionally, I prefer having the new hex values being in lowercase to be consistent with existing values. |
These new colors address color contrast issues in the default theme. These new colors meet WCAG 2.0 AA.