Update readme_banner.svg to support dark mode #813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme_banner.svg
is not visible on github.com when a browser is in dark mode. (Blackpath
>fill
on dark background. BTW: CSS colorcurrentColor
- not set in original SVG, but assumed by browsers, does not propagate in embedded SVG images, i.e. SVG does not take on color of hosting HTML page.)This PR adds a
<style>
tag to the SVG to accommodate darkmode in the browser - allowing the image to be seen when github.com is viewed by a browser in that state.(Based on my work done on bootstrap-dark circa. Dec. 2020)
i.e. added the compressed following to the SVG