Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme_banner.svg to support dark mode #813

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

vinorodrigues
Copy link
Contributor

readme_banner.svg is not visible on github.com when a browser is in dark mode. (Black path > fill on dark background. BTW: CSS color currentColor - not set in original SVG, but assumed by browsers, does not propagate in embedded SVG images, i.e. SVG does not take on color of hosting HTML page.)

This PR adds a <style> tag to the SVG to accommodate darkmode in the browser - allowing the image to be seen when github.com is viewed by a browser in that state.

(Based on my work done on bootstrap-dark circa. Dec. 2020)

i.e. added the compressed following to the SVG

<style>
  path{
    fill: #111;
  }
 @media( prefers-color-scheme: dark ) {
    path{
      fill: #EEE;
    }
  }
</style>

Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ashmaroli
Copy link
Member

Thank you very much, @vinorodrigues :)

@jekyllbot: merge +doc

@jekyllbot jekyllbot merged commit 2e9c7c0 into jekyll:master Oct 2, 2024
1 check passed
jekyllbot added a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants