Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally use the AnitomySharp library to extract media titles #9

Merged
merged 8 commits into from
Nov 9, 2023

Conversation

MisterMcDuck
Copy link
Contributor

I'm not sure if there will be much interest in this PR considering that it seems like many people using Jellyfin organize their media to use tvdb naming schemes, but this change adds the option to extract the titles of media folders for Anilist searches.
e.g.
[Golumpa] A Certain Scientific Railgun T (Toaru Kagaku no Railgun T) [FuniDub 1080p x264 AAC]
becomes
A Certain Scientific Railgun T

for the initial Anilist search. If this search fails, it falls back on the existing logic of exact folder searches.

This allowed me to quickly import my large unmodified media collection with reasonable success (~85% hit rate), rather than renaming all of the folders to match the Anilist/tvdb names.

Note: Due to the .NET jellyfin version I used a fork of AnitomySharp from @nielsvanvelzen located at https://github.com/nielsvanvelzen/AnitomySharp
This would be an external dependency, which I'm not sure is allowed/encouraged.

@nielsvanvelzen
Copy link
Member

I can probably look into publishing the library to NuGet if required. Might take some time though.

@Xabis
Copy link

Xabis commented Jul 16, 2023

Seems the AnitomySharp project is out of maintenance, As such, using the nuget package is not recommended.

I forked and updated the library to match the latest changes from erengy here: https://github.com/Xabis/AnitomySharp


Maintainers: is there something blocking this PR from moving forward? This has been open for 2 years now. I made similar modifications to this plugin locally, before stumbling on to this submission, so there is certainly interest here.

@crobibero
Copy link
Member

One thing that is blocking this PR is that it doesn't build. If someone would like to recreate this PR with the new AnitomySharp library feel free

@MisterMcDuck
Copy link
Contributor Author

I've added a reference to a net6 compatible AnitomySharp nuget package which I found. It compiles locally for me.

@crobibero crobibero added the feature This PR or Issue requests or introduces a new feature label Nov 9, 2023
@crobibero crobibero merged commit b922708 into jellyfin:master Nov 9, 2023
3 checks passed
This was referenced Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This PR or Issue requests or introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants