Fix error on unmount in syncplay menu

jellyfin · Sep 20, 2023 · 55a2ca3 · 55a2ca3
1 parent dbd068b
commit 55a2ca3
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/apps/experimental/components/AppToolbar/menus/SyncPlayMenu.tsx b/src/apps/experimental/components/AppToolbar/menus/SyncPlayMenu.tsx
@@ -56,16 +56,23 @@ const SyncPlayMenu: FC<SyncPlayMenuProps> = ({
     }, []);
 
     useEffect(() => {
+        let isMounted = true;
+
         const fetchGroups = async () => {
             if (api) {
-                setGroups((await getSyncPlayApi(api).syncPlayGetGroups()).data);
+                const response = await getSyncPlayApi(api).syncPlayGetGroups();
+                if (isMounted) setGroups(response.data);
             }
         };
 
         fetchGroups()
             .catch(err => {
                 console.error('[SyncPlayMenu] unable to fetch SyncPlay groups', err);
             });
+
+        return () => {
+            isMounted = false;
+        };
     }, [ api ]);
 
     const onGroupAddClick = useCallback(() => {