Skip to content

Commit

Permalink
Make Height editable on TV Channels
Browse files Browse the repository at this point in the history
  • Loading branch information
SenorSmartyPants authored and thornbill committed Feb 21, 2024
1 parent 534c820 commit 7e2b14b
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 0 deletions.
9 changes: 9 additions & 0 deletions src/components/metadataEditor/metadataEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ function onSubmit(e) {
DateCreated: getDateValue(form, '#txtDateAdded', 'DateCreated'),
EndDate: getDateValue(form, '#txtEndDate', 'EndDate'),
ProductionYear: form.querySelector('#txtProductionYear').value,
Height: form.querySelector('#txtHeight').value,
AspectRatio: form.querySelector('#txtOriginalAspectRatio').value,
Video3DFormat: form.querySelector('#select3dFormat').value,

Expand Down Expand Up @@ -650,6 +651,12 @@ function setFieldVisibilities(context, item) {
hideElement('#fldPlaceOfBirth');
}

if (item.MediaType === 'Video' && item.Type === 'TvChannel') {
showElement('#fldHeight');
} else {
hideElement('#fldHeight');
}

if (item.MediaType === 'Video' && item.Type !== 'TvChannel') {
showElement('#fldOriginalAspectRatio');
} else {
Expand Down Expand Up @@ -828,6 +835,8 @@ function fillItemInfo(context, item, parentalRatingOptions) {
const placeofBirth = item.ProductionLocations?.length ? item.ProductionLocations[0] : '';
context.querySelector('#txtPlaceOfBirth').value = placeofBirth;

context.querySelector('#txtHeight').value = item.Height || '';

context.querySelector('#txtOriginalAspectRatio').value = item.AspectRatio || '';

context.querySelector('#selectLanguage').value = item.PreferredMetadataLanguage || '';
Expand Down
4 changes: 4 additions & 0 deletions src/components/metadataEditor/metadataEditor.template.html
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ <h3 class="formDialogHeaderTitle">
<select is="emby-select" id="selectCustomRating" label="${LabelCustomRating}"></select>
</div>
</div>
<div id="fldHeight" class="inputContainer hide">
<input is="emby-input" id="txtHeight" type="number" pattern="[0-9]*" label="${LabelHeight}" />
<div class="fieldDescription">${ChannelHeightHelp}</div>
</div>
<div class="inlineForm">
<div id="fldOriginalAspectRatio" class="inputContainer hide">
<input is="emby-input" id="txtOriginalAspectRatio" type="text" label="${LabelOriginalAspectRatio}" />
Expand Down
2 changes: 2 additions & 0 deletions src/strings/en-us.json
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@
"Categories": "Categories",
"ChangingMetadataImageSettingsNewContent": "Changes to metadata or artwork downloading settings will only apply to new content added to your library. To apply the changes to existing titles, you'll need to refresh their metadata manually.",
"ChannelAccessHelp": "Select the channels to share with this user. Administrators will be able to edit all channels using the metadata manager.",
"ChannelHeightHelp": "Set height of video received on this channel. 720 or greater will mark this channel as HD.",
"ChannelNameOnly": "Channel {0} only",
"ChannelNumber": "Channel number",
"Channels": "Channels",
Expand Down Expand Up @@ -699,6 +700,7 @@
"LabelHardwareAccelerationType": "Hardware acceleration",
"LabelHardwareAccelerationTypeHelp": "Hardware acceleration requires additional configuration.",
"LabelHardwareEncoding": "Hardware encoding",
"LabelHeight": "Height",
"LabelHomeNetworkQuality": "Home network quality",
"LabelHomeScreenSectionValue": "Home screen section {0}",
"LabelHttpsPort": "Local HTTPS port number",
Expand Down

0 comments on commit 7e2b14b

Please sign in to comment.