-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Height editable on TV Channels #4181
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Back end has been merged. |
I think from a ux standpoint it would be better to have a drop down menu for common resolutions. |
Dropdown added. |
e6cda1e
to
2bbf6a2
Compare
I rebased this because sonarqube was flagging some issues that had been resolved since the PR was originally opened. The code changes look pretty good, I'm just adding a label so I remember to give it a quick test before approving + merging. 🙂 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
@jellyfin-bot rebase |
I'm sorry @thornbill, I'm afraid I can't do that. |
2bbf6a2
to
af19516
Compare
Rebase, fix merge conflict and force push. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Setting the "height" of a TV channel seems like a really strange concept from a user standpoint. I think it would be better if we call it "resolution" and display standard resolutions as the options with values being the height. I think I would just make the options |
I used height as it is an existing field and kept the label. I have no problem with the concept of updating these labels.
Or maybe those should be added as translatable resource strings. Feel free to modify this PR as you wish. |
Yeah to be clear I don't have any issues at all with the height field being used for the backend. I just think it can be presented in a more user friendly manner on the frontend. 🙂 |
af19516
to
d73f506
Compare
d73f506
to
8443b5d
Compare
Quality Gate passedIssues Measures |
Cloudflare Pages deployment
|
Changes
Editing metadata for a channel now allows user to set Height. Useful in determining which channels are HD.
Issues
Depends on jellyfin/jellyfin#8777
Useful in conjunction with jellyfin/jellyfin#8768