Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link documentation in fallback fonts helptext #4863

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Link documentation in fallback fonts helptext #4863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ac2645
Change fallback fonts help text to link documentation
felix920506 Oct 9, 2023
1f358cf
Change fallback fonts help text to link documentation
felix920506 Oct 9, 2023
5d7d5e6
Merge branch 'document-fallback-fonts' of https://github.com/felix920…
felix920506 Oct 16, 2023
6ee7be9
Move link into code
felix920506 Oct 16, 2023
4805d36
Partially accept Thornbill's suggestion
felix920506 Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/controllers/dashboard/encodingsettings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,9 @@ <h3 class="checkboxListLabel">${LabelHardwareEncodingOptions}</h3>
</div>
<button type="button" is="paper-icon-button-light" id="btnSelectFallbackFontPath" class="emby-input-iconbutton"><span class="material-icons search" aria-hidden="true"></span></button>
</div>
<div class="fieldDescription">${LabelFallbackFontPathHelp}</div>
<div class="fieldDescription">
<a is="emby-linkbutton" rel="noopener noreferrer" class="button-link" href="https://jellyfin.org/docs/general/administration/configuration#fonts" target="_blank">${LabelFallbackFontPathHelp}</a>
</div>
</div>
<div class="checkboxContainer checkboxContainer-withDescription">
<label>
Expand Down
2 changes: 1 addition & 1 deletion src/strings/en-us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1624,7 +1624,7 @@
"HeaderSelectFallbackFontPath": "Select Fallback Font Folder Path",
"HeaderSelectFallbackFontPathHelp": "Browse or enter the path of the fallback font folder to use for rendering ASS/SSA subtitles.",
"LabelFallbackFontPath": "Fallback font folder path",
"LabelFallbackFontPathHelp": "Specify a path containing fallback fonts for rendering ASS/SSA subtitles. The maximum allowed total font size is 20 MB. Lightweight and web-friendly font formats such as woff2 are recommended.",
"LabelFallbackFontPathHelp": "These fonts are used by some clients to render subtitles. Please refer to the documentation for more information.",
"EnableFallbackFont": "Enable fallback fonts",
"EnableFallbackFontHelp": "Enable custom alternate fonts. This can avoid the problem of incorrect subtitle rendering.",
"AspectRatioCover": "Cover",
Expand Down
Loading