Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix language/subtitle switcher when using gamepad - Backport #4860 #4892

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

thornbill
Copy link
Member

Changes
Backports the event code fix from #4860 to the 10.8 release branch

Issues
Fixes #3755

@thornbill thornbill added bug Something isn't working accessibility Concerns the accessibility of the web client labels Oct 19, 2023
@thornbill thornbill added this to the v10.8.12 milestone Oct 19, 2023
@thornbill thornbill requested review from a team as code owners October 19, 2023 16:22
@thornbill thornbill changed the base branch from master to release-10.8.z October 19, 2023 16:22
@thornbill thornbill removed the request for review from a team October 19, 2023 16:22
Raising the event code `13` (Enter) should be a lot more stable since `0`
is just the default and not assigned to any actual key [1]. This keycode
also has been standardized early enough to change it at this crucial part
of gamepad handling in my opinion.

[1] https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode

Fixes jellyfin#3755
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill thornbill merged commit d274d7f into jellyfin:release-10.8.z Oct 20, 2023
15 checks passed
@thornbill thornbill deleted the backport-4860 branch October 20, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Concerns the accessibility of the web client bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to change language or subs from movie menu using gamepad
3 participants