Only show IsAVC for video streams #6002
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Cloudflare Pages deployment
|
| @@ -107,7 +107,7 @@ function getMediaSourceHtml(user, item, version) { | |||
| if (stream.CodecTag) { | |||
| attributes.push(createAttribute(globalize.translate('MediaInfoCodecTag'), stream.CodecTag)); | |||
| } | |||
| if (stream.IsAVC != null) { | |||
| if (stream.Type === 'Video' && stream.IsAVC != null) { | |||
There was a problem hiding this comment.
Although this change looks fine, I see that IsAVC is supposed to be nullable. Did we accidentally set it for non-video streams?
There was a problem hiding this comment.
At least on my install, yes
There was a problem hiding this comment.
It probably becomes false here https://github.com/jellyfin/jellyfin/blob/72077490447d3ff588563cc7f8aa705e1a7e9ecc/Emby.Server.Implementations/Data/SqliteItemRepository.cs#L5627
TryGetBoolean doesn't seem to return null if the value in the DB is NULL.
Wouldn't result be assigned the value false instead of null?
https://github.com/jellyfin/jellyfin/blob/72077490447d3ff588563cc7f8aa705e1a7e9ecc/Emby.Server.Implementations/Data/SqliteExtensions.cs#L151
UPD:
Changed in jellyfin/jellyfin@1027792 after your request.
IsAVC is nullable, but never assigned to null from the DB, because TryGetBoolean doesn't accept nullable.
There was a problem hiding this comment.
TryGetBoolean doesn't seem to return null if the value in the DB is NULL.
Wouldn't result be assigned the value false instead of null?
No, it doesn't assign any value as the Try method returns false bc it's null inside of the DB.
We don't have to assign anything as the default value is null
There was a problem hiding this comment.
This means that we saved false in the database. I checked my database - not a single NULL (IsAvc column).
Could it be that is_avc in the ffprobe output is always set (not null)?
https://github.com/jellyfin/jellyfin/blob/2f602deb5a2ba3306e94c660173de273ee12a742/MediaBrowser.MediaEncoding/Probing/MediaStreamInfo.cs#L235
There was a problem hiding this comment.
@Bond-009 any thoughts on this?
|
No description provided.