Refactor media session to playback subscriber #6271
Conversation
thornbill
added
typescript
|
Cloudflare Pages deployment
|
| const album = item.Album || undefined; | ||
| const names = nowplayinghelper.getNowPlayingNames(item); | ||
| const artist = names[names.length - 1].text; | ||
| const title = names.length === 1 ? undefined : names[0].text; |
There was a problem hiding this comment.
This condition is unnecessary? If you use nullish coalescing, text will be undefined if the index doesn't exist.
There was a problem hiding this comment.
Good call... I tend to forget about using nullish coalescing when accessing by index. 😅
There was a problem hiding this comment.
I also see that you guys don't have https://www.typescriptlang.org/tsconfig/#noUncheckedIndexedAccess enabled, which in these cases it's a life saver
There was a problem hiding this comment.
Oh nice! I will enable that in a separate PR because it introduced 70 errors. 🙃
There was a problem hiding this comment.
Lucky you, I had a bunch of errors in Vue when I enabled it!
|
|
||
| return ServerConnections.getApiClient(item.ServerId).getScaledImageUrl(item.SeriesId, options); | ||
| } | ||
| if (item.ParentThumbItemId && item.ParentThumbImageTag) { |
There was a problem hiding this comment.
Add blank link between these two if blocks. All other conditionals have a blank line between blocks.
|
Changes
Issues
N/A