Add Device Icons for WebOS & Updated Infuse Naming #6281
Conversation
Cloudflare Pages deployment
|
|
I get this when I try the icon:
|
I'm sorry about that! I think I have this resolved. Additionally, while I was looking at my devices I realized Swiftfin wasn't in there on web for Apple either! So I've added both variants of Swiftfin. It looks like 1.0.1 and below is just Jellyfin tvOS/iOS/iPadOS and 1.1+ is Swiftfin tvOS/iOS/iPadOS. Additionally, I put the client name in for LG TV since it looks like we're looking at both client and device. Let me know if this scaling looks right! I added some items next to it for comparison:
|
|
Oh! Lastly, the Samsung.svg should be Samsungtv.svg. I updated that too. |
|
|
I don't think we should add padding to the logo image to fix what is really a bug with the css. (I also don't think that fixing that bug is a blocker for this PR. 🙂) |
Sounds good! I think on my last iteration the WebOS logo should match the same size as the other logos. Would you rather I trim that to just be the size of the actual logo? Let me know what works best! Aside from CSS changes, that might be a little beyond me haha. |
|
Yeah I would just make it the size of the logo itself. I had a fix for the css the other day but I think I deleted it at some point. I'll open a PR for it when I get it fixed again. 🙃 |
|
|
There we go! I kept updating the image but GitHub was showing it with huge vertical margins. I think that might be just how GitHub displays svgs? Either way, I've updated the image so it should just be exactly their Wikipedia SVG but white to mirror our existing logos. I'll also directly attach the svg to this comment just in case something weird is going on.
|
Infuse starting in 7.7 uses Infuse-Direct or Infuse-Library depending on the configuration. Adds parsing LG for WebOS.
Used in Dashboard for LG/WebOS Devices.
…yfin for WebOS, and I included Swiftfin both when it was Jellyfin XXX and Swiftfin XXX.
Remove Old Logo
thornbill
force-pushed
the
devicesWebOS
branch
from
0cf09f9 to
8364fda
Compare
|
Changes
First time doing anything on Web so please let me know if this isn't right!
Over in Swiftfin, I added Device Logos and I threw in a webOS (LG TVs) icon as well. I just wanted to add that logo and the logic so Jellyfin-Web had it as well. In my testing, 'LG Smart TV' covers all of the TVs (all 2 I had to test) but I'm unsure if there is a different name for projectors?
I am using webOS's icon from here: https://en.wikipedia.org/wiki/WebOS#/media/File:LG_WebOS_New.svg.
Additionally, during my Swiftfin changes, I found that Infuse doesn't use 'Infuse' as a device name after 7.7(?) and now uses 'Infuse-Direct' or 'Infuse-Library' on later versions. While I was adding WebOS, I added this change as well. I left the original just plain 'Infuse' for anyone running previous versions as well.
Issues
#6280