Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tonemapping helptext make sense #6354

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

make tonemapping helptext make sense #6354

wants to merge 4 commits into from
+4 −5

Conversation

felix920506
Copy link
Member

@felix920506 felix920506 commented Nov 27, 2024 •
edited
Loading

per discussion on matrix yesterday, remove unnecessary clutter from the helptext

@felix920506 felix920506 requested a review from a team as a code owner November 27, 2024 15:01
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 27, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 2a58804
Status ✅ Deployed!
Preview URL https://1930197c.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

joshuaboniface
joshuaboniface approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think they can be simplified and cleaned up a lot more but this is a good start. Feel free to ignore but I think these are slightly shorter and clearer.

src/strings/en-us.json Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
@felix920506
Copy link
Member Author

I think we should have @nyanmisaka or @gnattu check if your suggestions are still accurate as I feel like they slightly change the meaning

@felix920506 felix920506 requested a review from gnattu December 23, 2024 04:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimGels TimGels TimGels approved these changes

@gnattu gnattu gnattu approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

@Shadowghost Shadowghost Shadowghost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@felix920506 @jellyfin-bot @Shadowghost @joshuaboniface @gnattu @TimGels