Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminology cleanup: Docs for built-in node migration #4496

Merged
merged 3 commits into from
Aug 15, 2021

Conversation

daniel-beck
Copy link
Contributor

Add redirect and docs page for the built-in node name and label migration, corresponds to jenkinsci/jenkins#5425.

Deliberately not linked from the menu as this is basically "ephemeral" documentation -- it won't have much value in a year or two. The entry point is the admin monitor in Jenkins.

@daniel-beck daniel-beck requested a review from a team as a code owner August 7, 2021 09:17
@probot-autolabeler probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label Aug 7, 2021
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Does it also worth a blogpost?

@timja timja merged commit c5831c9 into jenkins-infra:master Aug 15, 2021
@jsoref
Copy link
Contributor

jsoref commented Aug 26, 2021

The merged PR text includes screenshot here.

Here's a screenshot:
image

Personally, I have a list of questions about this cleanup which I've left via Slack. Happy to talk things over.

Fwiw, I had to change ~30 jobs (29 classic and one pipeline). And I have no idea if what I did will work (so far, the one pipeline is running fine on the master side of the transition).

I used /label/master/ to find them all and then changed them to reference master||built-in instead, and now I have to use /label/master%7C%7Cbuilt-in/ to see them, but I'm hoping that on the other side they'll still run.

I think it'd be helpful to suggest actual before & after for classic and pipeline (and probably matrix). Some of us have inherited systems that are >10 years old where no one remembers how things work (many of these jobs haven't been intentionally run in that time).

@jsoref
Copy link
Contributor

jsoref commented Aug 26, 2021

Oh, the most basic question is "How does one undo this?",


From a linguistic perspective:

-Jenkins to version 2.307 or newer
+Jenkins to version 2.307 and newer

@daniel-beck
Copy link
Contributor Author

via Slack

Could you provide a link?

Oh, the most basic question is "How does one undo this?"

Seemed unnecessary, given the workaround which is essentially the same for the vast majority of use cases (label expressions). Could you explain why reverting is useful but the provided workaround is not?

@jsoref
Copy link
Contributor

jsoref commented Aug 26, 2021

Could you provide a link?

https://kubernetes.slack.com/archives/C09R5RQNL/p1629937472001100

Could you explain why reverting is useful but the provided workaround is not?

Frankly, I have no idea. It's just that I don't know what it's actually doing, and it seems like it'd be easier to have a button to go both ways than to force me (if things are already burning) to try to do something else.

Keep in mind that I really don't know what might explode, but it sounds scary, and it seems like it'd be a pretty easy thing for Jenkins to be able to do, click to migrate and click to roll-back are much easier for peace-of-mind than "click to jump off a cliff" + "follow amorphous steps to half undo in a way that might fix your fires".

@daniel-beck
Copy link
Contributor Author

I thought you were referring to the CDF Slack and was surprised when I didn't find anything.

I'm not signing up for yet another third party service to receive feedback, sorry.

@jsoref
Copy link
Contributor

jsoref commented Aug 26, 2021

Sorry. I'll put it into the right slack. I miss irc.

@daniel-beck
Copy link
Contributor Author

daniel-beck commented Aug 26, 2021

the right slack

I'm not sure the CDF Slack is much better, but it's the only one I could think of -- mostly used for CDF/LF interactions and such.

I miss irc.

We still have that, just on libera.chat: https://www.jenkins.io/chat/

And in case you haven't followed recent developments, there's also https://community.jenkins.io/

@jsoref
Copy link
Contributor

jsoref commented Aug 26, 2021

I haven't followed. And the last think I need is another discourse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Jenkins documentation, including user and developer docs, solution pages, etc. on-hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants