Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updatecli] Track the Karpenter Linux Node AMIs versions #144

Open
dduportal opened this issue Feb 19, 2025 · 3 comments
Open

[updatecli] Track the Karpenter Linux Node AMIs versions #144

dduportal opened this issue Feb 19, 2025 · 3 comments
Labels

Comments

@dduportal
Copy link
Contributor

The manifest https://github.com/jenkins-infra/terraform-aws-sponsorship/blob/main/updatecli/updatecli.d/eks-ami-release.yaml already tracks the node AMi version for our Linux AL2023 Managed Node Group.

We also want this update to be done on the Karpenter node pools

@saurabhraghuvanshii
Copy link

can I give try to it .

@dduportal dduportal removed the good first issue Good for newcomers label Feb 19, 2025
@dduportal
Copy link
Contributor Author

dduportal commented Feb 19, 2025

can I give try to it .

I mistakenly added the good-first-issue label on this issue. It's not an easy on because it requires both updatecli and Terraform knowledge.

If you want to contribute, I recommend you to:

  • Search for ## TODO: track with updatecli comment in the code
  • For each occurence, check if there isn't already a manifest tracking it:
    • If yes: feel free to open a PR (type "chore") removing the comment
    • If no, then you can open an issue explaining which element is to be tracked and detail how you would to it.
  • For each new issue opened above, you can start providing an updatecli PR. We expect the PRs:
    • to have been tested locally on your machine (provide an excerpt of log output of your try)
    • the PR checks to be successful when ready to review

@saurabhraghuvanshii
Copy link

ok sir I will try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants