Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

fix: compatible with k8s 1.16 api #45

Closed
wants to merge 1 commit into from
Closed

fix: compatible with k8s 1.16 api #45

wants to merge 1 commit into from

Conversation

jiangytcn
Copy link

support kube api 1.16+

part of jenkins-x/jx#6385

Why:

This change addresses the need by:

Signed-off-by: Jiang Yitao <[email protected]>
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: pmuir

If they are not already assigned, you can assign the PR to them by writing /assign @pmuir in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

Hi @jiangytcn. Thanks for your PR.

I'm waiting for a jenkins-x-charts or jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abayer
Copy link
Contributor

abayer commented Dec 30, 2019

These changes are also in #44, fyi.

@jiangytcn
Copy link
Author

thanks @abayer

@jiangytcn jiangytcn closed this Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants