Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

feat: allow a custom PVC storageClassName #60

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

vbehar
Copy link
Contributor

@vbehar vbehar commented May 29, 2020

add a new value pvc.storageClassName to specify a custom storage class name for the PVC configmap

add a new value `pvc.storageClassName` to specify a custom storage class name for the PVC configmap

Signed-off-by: Vincent Behar <[email protected]>
@jenkins-x-bot
Copy link
Contributor

Hi @vbehar. Thanks for your PR.

I'm waiting for a jenkins-x-charts or jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@vbehar
Copy link
Contributor Author

vbehar commented May 29, 2020

/assign @abayer
thanks ;-)

@abayer
Copy link
Contributor

abayer commented Jun 3, 2020

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit d37bfc5 into jenkins-x-charts:master Jun 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants