Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration as code support #147

Merged
merged 13 commits into from
Apr 12, 2019
Merged

Add configuration as code support #147

merged 13 commits into from
Apr 12, 2019

Conversation

timja
Copy link
Member

@timja timja commented Mar 31, 2019 •
edited
Loading

Review #146 first, this adds a small amount of code on top of that

@timja
Copy link
Member Author

timja commented Mar 31, 2019

Linking: jenkinsci/configuration-as-code-plugin#809

@timja
Copy link
Member Author

timja commented Apr 10, 2019

@gavinfish could you take a look please?

gavinfish
gavinfish approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@gavinfish gavinfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinfish
Copy link
Member

Thanks @timja for your great contribution here!

@gavinfish gavinfish merged commit 82687ac into jenkinsci:dev Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinfish gavinfish gavinfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timja @gavinfish