Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CD #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

anees264
Copy link

@anees264 anees264 commented Jun 5, 2023

Enable CD

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to incrementalify the plugin.
Make sure to update your pom.xml to reflect <version>${changelist}</version> and <changelist>999999-SNAPSHOT</changelist> inside the <properties> block.
A .mvn/extensions.xml with the following content is missing too: https://github.com/jenkinsci/archetypes/blob/master/common-files/.mvn/extensions.xml

@NotMyFault
Copy link
Member

Hey,

if you're still interested in enabling CD for your plugin, please address my feedback above.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants