Support latest Docker Engine and Jenkins remoting image #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microscotch
approved these changes
Nov 21, 2019
|
What is the status of this plugin? I see that @microscotch approved this PR in 2019 but more than a year later it hasn't been merged... That's the only Jenkins plugin I know of that allows me to easily specify multiple sidecar containers in a pipeline. The built-in I'm stuck with an older version of Docker and an older version of the remoting image until this PR is merged. |
|
Probably it is abandoned. Check jenkins.io for the process to adopt it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following change in the remoting image breaks Docker Slaves, which hardcodes uid/gid to 10000 when running the containers: jenkinsci/docker-agent@19215a4
The following change in Docker to default to
--ipc=privatealso breaks Docker Slaves: moby/moby#35621This PR should address those 2 issues.