Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SKIP_FAILJOB_ON_STOP_ERROR flag #246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RickeyWard
Copy link

@RickeyWard RickeyWard commented Jan 25, 2022

Allow passing jobs that fail to stop/rm in time. Some large builds can succeed and fail to stop due to timeouts (increasing the timeout is not always an adequate solution) more info JENKINS-42322 (this is marked resolved but is still getting comments and some like my time are still having issues)

The idea is that a docker error after the build succeeds should have an escape hatch to let jobs be marked as successful.

JAVA_OPTS=-Dorg.jenkinsci.plugins.docker.workflow.client.DockerClient.SKIP_FAILJOB_ON_STOP_ERROR=true

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
    // Ensure you have provided tests - that demonstrates feature works or fixes the issue

I'm unsure how to write a test that doesn't have outside dependency on an image that exists just to hang, open to suggestions.

Allow passing of jobs that fail to stop/rm in time. Some large builds can succeed and fail on stop due to timeouts (increasing the timeout is not always an adequate solution) more info JENKINS-42322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant