Add SKIP_FAILJOB_ON_STOP_ERROR flag #246
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing jobs that fail to stop/rm in time. Some large builds can succeed and fail to stop due to timeouts (increasing the timeout is not always an adequate solution) more info JENKINS-42322 (this is marked resolved but is still getting comments and some like my time are still having issues)
The idea is that a docker error after the build succeeds should have an escape hatch to let jobs be marked as successful.
JAVA_OPTS=-Dorg.jenkinsci.plugins.docker.workflow.client.DockerClient.SKIP_FAILJOB_ON_STOP_ERROR=true
// Ensure you have provided tests - that demonstrates feature works or fixes the issue
I'm unsure how to write a test that doesn't have outside dependency on an image that exists just to hang, open to suggestions.