[JENKINS-70464] added new test case for PluginImpl.java

[abhishekmaity]

In response to #114

• added a new test case PluginImplTest.java
• added a new dependency jopt-simple in pom.xml as automated by IntelliJ IDE

Testing done

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

@abhishekmaity neither of the proposed changes are a useful addition to the plugin. We're looking for useful additions to the plugin.

The addition of an unused dependency is a net negative because it adds maintenance overhead and brings more dependencies into Jenkins when the plugin is run.

The addition of a test that asserts nothing about the production code of the plugin is a net negative because asserting that variable assignment works in Java is not helping the plugin test suite.

The referenced issue is stating that the pull request should increase the test coverage of the plugin. The test coverage report for this pull request will show no increase in test coverage because the test does not invoke any of the plugin code.

I'm closing this pull request. If you'd like to continue on the path of submitting a pull request that improves test coverage, you'll need to actually improve test coverage.

[abhishekmaity]

Okay