Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jcasc compatibility #24

Merged
merged 34 commits into from
Jun 26, 2019
Merged

Jcasc compatibility #24

merged 34 commits into from
Jun 26, 2019

Conversation

jonbrohauge
Copy link
Contributor

Enable plugin to be compatible with configuration-as-code

oleg-nenashev and others added 30 commits January 12, 2018 13:51
@oleg-nenashev
- [x] Update Plugin POM
0869c38 
- [x] Bump Jenkins core to 1.625.3
- [x] Resolve the reported issues
- [x] Add Jenkinsfile
@jonbrohauge
Update parent-plugin version to 3.18 to comply with version JCASC is …
b9abaa8 
…using
@jonbrohauge
Add jenkins.version and java.level properties, and align them with JCASC
0257530
@jonbrohauge
Add test dependency to JCASC.
3e83d13
@jonbrohauge
Ignore due to the need to rework the test
796f8e7
@jonbrohauge
Add test for JCASC
6126dd3
@jonbrohauge
Actually add the test
2e26583
@jonbrohauge
Initial Commit
09fdc41
@jonbrohauge
Prepare more CASC tests
b8ef166
@jonbrohauge
Some tests work. The rest are WIP
80f80b3
test: Now added Makefile with test commands!
a633204 
Through docker (and docker-compose)!
@jonbrohauge
Merge pull request #1 from x10an14/dockerize_makefile_tests
e1bcef0 
test: Now added Makefile with test commands!
test: Re-introduced logPublisherWorkflowStep test =)
d873b8e
fix: docker-compose up doesn't support --rm
d613f5e
fix: Now Jenkins is available on port 8081 and boots
f269c53
refactor/fix: Strip trailing whitespace and refactor Makefile
fcac2eb
@jonbrohauge
Update .gitignore
a90d921
@jonbrohauge
Merge branch 'jcasc-compatibility' of github.com:jonbrohauge/log-pars…
ed25b98 
…er-plugin into jcasc-compatibility
@jonbrohauge
Add logger to try to debug
8d0b57f
@jonbrohauge
Formatting?
172c555
@jonbrohauge
Update .gitignore
8e16ead 
Signed-off-by: Jon Brohauge <[email protected]>
@jonbrohauge
Update .gitignore
363c1f9 
Signed-off-by: Jon Brohauge <[email protected]>
@jonbrohauge
setRule() + Formatting
a3c48c6 
Signed-off-by: Jon Brohauge <[email protected]>
@jonbrohauge
Formatting
d629286 
Signed-off-by: Jon Brohauge <[email protected]>
@jonbrohauge
Rename parsingRulesGlobal to rule
8a5bb7d 
Signed-off-by: Jon Brohauge <[email protected]>
@jonbrohauge
Update @symbol to adhere to naming convention
4a1a94c
@jonbrohauge
revert set/getRule()
8cf2408 
Signed-off-by: Jon Brohauge <[email protected]>
@slide
JCasC changes for Jelly
c3098d9
@jonbrohauge
Merge pull request #2 from slide/jcasc-compatibility
f79e0c4 
JCasC changes for Jelly
@jonbrohauge
Ignore test not working, probably due to major refactoring
4745f29 
Signed-off-by: Jon Brohauge <[email protected]>
@jonbrohauge
Indentation
aec04ad 
Signed-off-by: Jon Brohauge <[email protected]>
@jonbrohauge
Copy link
Contributor Author

With massive help from @slide to update plugin to make it JCASC compatible, please review
@reviewbybees
@oleg-nenashev

@jonbrohauge jonbrohauge mentioned this pull request Nov 6, 2018
Closed
@oleg-nenashev
Copy link
Member

Next time please use @jenkinsci/code-reviewers instead of @reviewbybees. https://github.com/reviewbybees/about

oleg-nenashev
oleg-nenashev reviewed Nov 6, 2018
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
src/main/java/hudson/plugins/logparser/LogParserPublisher.java Show resolved Hide resolved
@jonbrohauge
Copy link
Contributor Author

ping @jborghi to keep you in the loop.

@ewelinawilkosz
Copy link

@recena any chance for a release? or you're not maintaining the plugin any more?

@darxriggs
Copy link

@recena ping

@jonbrohauge
Copy link
Contributor Author

Linking: jenkinsci/configuration-as-code-plugin#809

@slide
Copy link
Member

slide commented Apr 10, 2019

LGTM 👍

@ayoubeddafali
Copy link

Any news ?

@jampo
Copy link

jampo commented Apr 24, 2019

We are using the plugin as well and would love a release for JCasC support :)

@bdominguez
Copy link

Any news?

@jonbrohauge
Copy link
Contributor Author

Just saw this https://groups.google.com/forum/#!msg/jenkinsci-dev/e76TyU_MBVU/Psrnzdz-BQAJ on the jenkinsci-dev mailing list. @hypery2k is stepping up to be a maintainer.
All hail @hypery2k

@hypery2k
Copy link
Contributor

yeah, would like to merge some of the PRs ;)

@bdominguez
Copy link

@hypery2k thanks!! I would love to see this PR merged!!

@hypery2k hypery2k merged commit 1b2959b into jenkinsci:master Jun 26, 2019
@jonbrohauge jonbrohauge deleted the jcasc-compatibility branch June 26, 2019 08:20
@oleg-nenashev
Copy link
Member

Thanks @hypery2k ! Let me know if you need any help with the release

@hypery2k
Copy link
Contributor

thanks. So far everything seems to work. Plan to release new version next week

@oleg-nenashev
Copy link
Member

Thanks @hypery2k ! Let me know if you need any help with the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev left review comments

@ndeloof ndeloof ndeloof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jonbrohauge @oleg-nenashev @ewelinawilkosz @darxriggs @slide @ayoubeddafali @jampo @bdominguez @hypery2k @ndeloof