Modify getChannelId and convertChannelNameToId for efficient chan…

…nel ID retrieval (#977)
jenkinsci · Jun 4, 2024 · d07f1ea · d07f1ea
1 parent a2edd2b
commit d07f1ea
Showing 1 changed file with 48 additions and 2 deletions.
diff --git a/src/main/java/jenkins/plugins/slack/cache/SlackChannelIdCache.java b/src/main/java/jenkins/plugins/slack/cache/SlackChannelIdCache.java
@@ -73,6 +73,9 @@ public long getRetryInterval() {
     }
 
     public static String getChannelId(String botUserToken, String channelName) throws ExecutionException, InterruptedException, AbortException {
+        if (channelName.matches("^(C[A-Z0-9]{8}|G[A-Z0-9]{10}||D[A-Z0-9]{8})$")) {
+            return channelName;
+        }
         Map<String, String> channelNameToIdMap = CHANNEL_METADATA_CACHE.get(botUserToken);
         String channelId = channelNameToIdMap.get(channelName);
 
@@ -93,10 +96,53 @@ public static String getChannelId(String botUserToken, String channelName) throw
     }
 
     private static Map<String, String> convertChannelNameToId(CloseableHttpClient client, String token, Map<String, String> channels, String cursor) throws IOException {
+        convertPublicChannelNameToId(client, token, channels, cursor);
+        convertPrivateChannelNameToId(client, token, channels, cursor);
+        return channels;
+    }
+
+    private static Map<String, String> convertPublicChannelNameToId(CloseableHttpClient client, String token, Map<String, String> channels, String cursor) throws IOException {
+        RequestBuilder requestBuilder = RequestBuilder.get("https://slack.com/api/conversations.list")
+                .addHeader("Authorization", "Bearer " + token)
+                .addParameter("exclude_archived", "true")
+                .addParameter("types", "public_channel")
+                .addParameter("limit", "999");
+
+        if (cursor != null) {
+            requestBuilder.addParameter("cursor", cursor);
+        }
+        ResponseHandler<JSONObject> standardResponseHandler = getStandardResponseHandler();
+        JSONObject result = client.execute(requestBuilder.build(), standardResponseHandler);
+
+        if (!result.getBoolean("ok")) {
+            logger.warning("Couldn't convert channel name to ID in Slack: " + result);
+            return channels;
+        }
+
+        JSONArray channelsArray = result.getJSONArray("channels");
+        for (int i = 0; i < channelsArray.length(); i++) {
+            JSONObject channel = channelsArray.getJSONObject(i);
+
+            String channelName = channel.getString("name");
+            String channelId = channel.getString("id");
+
+            channels.put(channelName, channelId);
+        }
+
+        cursor = result.getJSONObject("response_metadata").getString("next_cursor");
+        if (cursor != null && !cursor.isEmpty()) {
+            return convertPublicChannelNameToId(client, token, channels, cursor);
+        }
+
+        return channels;
+    }
+
+    private static Map<String, String> convertPrivateChannelNameToId(CloseableHttpClient client, String token, Map<String, String> channels, String cursor) throws IOException {
         RequestBuilder requestBuilder = RequestBuilder.get("https://slack.com/api/conversations.list")
                 .addHeader("Authorization", "Bearer " + token)
                 .addParameter("exclude_archived", "true")
-                .addParameter("types", "public_channel,private_channel");
+                .addParameter("types", "private_channel")
+                .addParameter("limit", "999");
 
         if (cursor != null) {
             requestBuilder.addParameter("cursor", cursor);
@@ -121,7 +167,7 @@ private static Map<String, String> convertChannelNameToId(CloseableHttpClient cl
 
         cursor = result.getJSONObject("response_metadata").getString("next_cursor");
         if (cursor != null && !cursor.isEmpty()) {
-            return convertChannelNameToId(client, token, channels, cursor);
+            return convertPrivateChannelNameToId(client, token, channels, cursor);
         }
 
         return channels;