Jenkins Credentials filled with 'sonar-gerrti:{GUID}' secrets

jenkinsci · Jan 15, 2022 · db8f264 · db8f264
1 parent e1cf83f
commit db8f264
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/sonargerrit/gerrit/GerritHttpCredentials.java b/src/main/java/org/jenkinsci/plugins/sonargerrit/gerrit/GerritHttpCredentials.java
@@ -37,7 +37,8 @@ public static GerritHttpCredentials get() {
 
   /** @return Empty if username and password are null */
   public Optional<String> migrate(String username, Secret password) {
-    if (Util.fixEmpty(username) == null && password == null) {
+    if (Util.fixEmpty(username) == null
+        && (password == null || Util.fixEmpty(password.getPlainText()) == null)) {
       return Optional.empty();
     }
     StandardUsernamePasswordCredentials credentials =