Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison of Matrix configurations done by Matrix Root Project #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

papajulio
Copy link
Contributor

This is a tentative fix to make work both options "Throttle this project alone" and "Throttle Matrix configuration builds" together.

I don't know if this is completely correct, in my tests is working but I would like to get feedback before merging it and testing it thoroughly with all the possible combinations.

@cloudbees-pull-request-builder

plugins » throttle-concurrent-builds-plugin #35 SUCCESS
This pull request looks good

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev
Copy link
Member

Thanks for the PR and sorry for the delay.
I'll try to review it on the next week

@oleg-nenashev oleg-nenashev self-assigned this Jul 3, 2014
@oleg-nenashev
Copy link
Member

#20 seem to be preferable. In any case, one of the implementation will be included to the next major version

@oleg-nenashev oleg-nenashev added this to the 1.9 milestone Oct 9, 2014
@oleg-nenashev oleg-nenashev mentioned this pull request Oct 9, 2014
@papajulio papajulio closed this Apr 13, 2015
@papajulio papajulio reopened this Apr 13, 2015
@papajulio papajulio closed this Feb 21, 2017
@oleg-nenashev
Copy link
Member

@papajulio Yeh, the "next major version" has never happened :(

@papajulio
Copy link
Contributor Author

@oleg-nenashev yeah sorry, I was doing some cleaning. If you prefer to leave it open I don't have any problem but I thought this was dead.

I did use this code for a year or so in my previous company and it worked ok :)

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Feb 21, 2017

Yeah, something should change at some point.
I also changed the company and thus had no time to maintain all the stuff. Will reopen it just in case we find a new active maintainer. Maybe I will also find some time, but it is hard to commit on it

@oleg-nenashev oleg-nenashev reopened this Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants