Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for limiting job concurrency based on one or more build parameters (replaces pull request #9) #33

Closed
wants to merge 31 commits into from

Conversation

jmozmoz
Copy link

@jmozmoz jmozmoz commented Jan 10, 2016

Latest version of pull request for add support for limiting job concurrency based on one or more build parameters #9 including merges of upstream changes (not included in original pull request).

joemiller and others added 27 commits February 25, 2013 14:10
…currency_by_job_parameters

basic support for limiting concurrent job runs by parameters
Conflicts:
	.gitignore
	src/main/java/hudson/plugins/throttleconcurrents/ThrottleJobProperty.java
	src/main/java/hudson/plugins/throttleconcurrents/ThrottleQueueTaskDispatcher.java
	src/main/resources/hudson/plugins/throttleconcurrents/Messages.properties
	src/test/java/hudson/plugins/throttleconcurrents/ThrottleJobPropertyTest.java
- Rename limitOneJobByParams to paramsToUseForLimit
- Change style of method header comment
Conflicts:
	src/main/java/hudson/plugins/throttleconcurrents/ThrottleJobProperty.java
	src/main/java/hudson/plugins/throttleconcurrents/ThrottleQueueTaskDispatcher.java
@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@jmozmoz
Copy link
Author

jmozmoz commented Jan 10, 2016

At the moment, there a compilation errors in this branch. So it needs some more work.

@oleg-nenashev
Copy link
Member

@jmozmoz Thanks a lot for taking the action on this pull request

@lcasey001
Copy link

+1 for this

@vmoravec
Copy link

vmoravec commented Feb 1, 2016

+1 a big one. thanks.

@jmozmoz
Copy link
Author

jmozmoz commented Feb 1, 2016

If I run mvn package on my computer for the master branch of this repository (7a6b581) I get the same 5 test failures as for my branch. So I really would appreciate some help in solving these failures. Anybody has any idea what is going on?

@oleg-nenashev
Copy link
Member

yes, somebody needs to investigate the test failures

@balldarrens
Copy link

This is fixed, with some alterations to tests and the pom.
https://github.com/balldarrens/throttle-concurrent-builds-plugin/commit/6394b9866bf93af23d0f9515dc802b7afc551537
I will send it to PR.

@balldarrens
Copy link

Here is the new PR: #38

@oleg-nenashev
Copy link
Member

#38 has been integrated, so closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants