Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CCU-Jack MQTT port #2361

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Fix for CCU-Jack MQTT port #2361

merged 2 commits into from
Jul 15, 2023

Conversation

dega2
Copy link
Contributor

@dega2 dega2 commented Jul 14, 2023

Fix for CCU-Jack MQTT port from 1833 to 1883

Related Issue

#2360

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

  • None

Possible Drawbacks

  • if someone has manually changed the MQTT port in CCU-Jack config to 1833 it will break the config

Verification Process

Tested it from my fork in my HASS installation successful

Release Notes

  • Fixed a non standard MQTT port for CCU-Jack to standart port 1883

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

@jens-maus
Copy link
Owner

Please also modify the config.yaml of the home-assistant-addon-dev directory in the same way.

@dega2
Copy link
Contributor Author

dega2 commented Jul 15, 2023

Done

@jens-maus jens-maus merged commit eaaaac5 into jens-maus:master Jul 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants