integrate with OpenCensus and Ocagent exporter #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reyang do you think that you could possibly update this with the proper changes to vendor/Gopkg.toml/Gopkg.lock? One of our goals is to have a repeatable demo people can use later, your PR doesn't introduce the needed bits to update vendor. |
jeremyrickard
requested changes
Sep 17, 2018
| @@ -73,7 +100,7 @@ func main() { | |||
| http.Handle("/metrics", promhttp.Handler()) | |||
| http.Handle("/", instrumentHandler(throttledHandler)) | |||
| // go rpsTelemetryCalculator(ctr) | |||
| log.Fatal(http.ListenAndServe(":8080", nil)) | |||
| log.Fatal(http.ListenAndServe(":8080", &ochttp.Handler{Propagation: &tracecontext.HTTPFormat{}})) | |||
There was a problem hiding this comment.
where is this defined? When I try to compile this, it doesn't compile:
---> Running in 8f6a5333361a
# rpsdemo/cmd/app
cmd/app/app.go:92:71: undefined: tracecontext
There was a problem hiding this comment.
missed one line in the import: "go.opencensus.io/plugin/ochttp/propagation/tracecontext"
|
@jeremyrickard, good point, let me switch to vendor. |
|
Dope, thanks @reyang I’ll pull this in to the other repo and give it a whirl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration with OpenCensus and LocalForwarder.
Use environment variable OCAGENT_TRACE_EXPORTER_ENDPOINT to specify the LocalForwarder endpoint.