Change "FLAGS_BY_GROUP" in backends.py to accept array of groups #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the logic of the "FLAGS_BY_GROUP" parameter such that it can accept an array of group names. This will allow multiple groups to be configured with the respective flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the logic of the "FLAGS_BY_GROUP" parameter such that it can accept an array of group names. This will allow multiple groups to be configured with the respective flag.
I'm not a Django or Netbox expert, and I'd consider myself more of a beginner for both. Please double check this work and verify if this makes sense on the grander scheme to implement. I wanted to set one SAML group so it only got "is_staff", and I wanted to set another SAML group so it got both "is_staff" and "is_superuser", but found the plugin would accept the array without crashing, but would only manage the flag for the first group in the array. While looking through the issue tracker for related questions, I found #77 so I decided to take this on myself and create a pull request.