Rbac generate #252
Merged
Rbac generate #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
size/L
|
Lgtm 👍 could you add a description to the PR |
tfadeyi
approved these changes
Aug 5, 2021
jakexks
reviewed
Aug 5, 2021
| @@ -30,7 +30,7 @@ type Config struct { | |||
| OrganizationID string `yaml:"organization_id"` | |||
| // ClusterID is the cluster that the agent is scanning. | |||
| ClusterID string `yaml:"cluster_id"` | |||
| DataGatherers []dataGatherer `yaml:"data-gatherers"` | |||
| DataGatherers []DataGatherer `yaml:"data-gatherers"` | |||
There was a problem hiding this comment.
data-gatherers seems inconsistent with cluster_id and organization_id. Would _ be better?
Suggested change
| DataGatherers []DataGatherer `yaml:"data-gatherers"` | |
| DataGatherers []DataGatherer `yaml:"data_gatherers"` |
There was a problem hiding this comment.
👍 We'll see if we can change it in another PR. Changing that now would require a couple of other changes in the platform side also.
jakexks
reviewed
Aug 5, 2021
Change the DataGatherer struct
jakexks
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a string of RBAC from GVRs.
#250