Add documentation and examples #7
Conversation
jetstack-bot
added
the
dco-signoff: no
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: j-fuentes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
approved
Signed-off-by: Jose Fuentes <[email protected]>
Signed-off-by: Jose Fuentes <[email protected]>
Signed-off-by: Jose Fuentes <[email protected]>
Signed-off-by: Jose Fuentes <[email protected]>
Signed-off-by: Jose Fuentes <[email protected]>
jetstack-bot
added
dco-signoff: yes
Signed-off-by: Jose Fuentes <[email protected]>
|
|
||
| # STAGE 2 | ||
| # Use a distroless nonroot base image for just our executable | ||
| FROM gcr.io/distroless/base:nonroot |
There was a problem hiding this comment.
Instead of using multi stage builds, which don't play well with go's module caching, consider using 'go_container.sh' from 'kind' which makes use of a docker volume to cache go dependencies, giving you host-like performance 😀 this works okay, but is just a bit slow for iterative development: https://github.com/kubernetes-sigs/kind/blob/master/hack/go_container.sh
There was a problem hiding this comment.
Will do in a separate PR: #8
| export IMAGE_NAME=<my image> | ||
| make build-docker-image | ||
| make push-docker-image | ||
| ``` |
There was a problem hiding this comment.
We should get some images published at some point soon to to avoid this 😀
There was a problem hiding this comment.
Yes, we need to build images and binaries from Prow. Not done yet.
Signed-off-by: Jose Fuentes <[email protected]>
Signed-off-by: Jose Fuentes <[email protected]>
|
/lgtm |
This adds a decent readme and some other documentation (./docs). It adds a tutorial on how to deploy preflight as a cronjob.
Additionally, it adds a Dockerfile.