Use the URL Override within the checker vs version, meaning the metri…

…c labels display the override URI instead of the original, as this could cause confusion down the line

pkg/controller/checker/checker.go

@@ -54,6 +54,11 @@ func (c *Checker) Container(ctx context.Context, log *logrus.Entry,
 			currentTag, currentSHA)
 	}
 
+	if opts.OverrideURL != nil && *opts.OverrideURL != imageURL {
+		log.Debugf("overriding image URL %s -> %s", imageURL, *opts.OverrideURL)
+		imageURL = *opts.OverrideURL
+	}
+
 	if opts.UseSHA {
 		result, err := c.isLatestSHA(ctx, imageURL, statusSHA, opts)
 		if err != nil {

pkg/version/version.go

@@ -44,10 +44,6 @@ func (v *Version) Run(refreshRate time.Duration) {
 // LatestTagFromImage will return the latest tag given an imageURL, according
 // to the given options.
 func (v *Version) LatestTagFromImage(ctx context.Context, imageURL string, opts *api.Options) (*api.ImageTag, error) {
-	if override := opts.OverrideURL; override != nil && len(*override) > 0 {
-		v.log.Debugf("overriding image lookup %s -> %s", imageURL, *override)
-		imageURL = *override
-	}
 	tagsI, err := v.imageCache.Get(ctx, imageURL, imageURL, nil)
 	if err != nil {
 		return nil, err