Fixes #323 - IllegalStateException in ContentSource.demand(). #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the application BiFunction passed to `request.response(BiFunction)` was called at the "headers" event. Eventually, a `Publisher<T>` was returned to the application that could subscribe to it, triggering demand to the internal `Publisher<Chunk>`, which is triggering the read of `Chunk`s from the `Content.Source`. At the same time, the "content source event" may be delivered, triggering also the read of `Chunk`s from the `Content.Source`. The solution was to delay the call of the application BiFunction at the "content source event". In this way, there is only one trigger to read `Chunk`s from the `Content.Source`: when the application demands on the `Publisher<T>` returned to the application. Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
Dec 6, 2023
Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the application BiFunction passed to
request.response(BiFunction)was called at the "headers" event.Eventually, a
Publisher<T>was returned to the application that could subscribe to it, triggering demand to the internalPublisher<Chunk>, which is triggering the read ofChunks from theContent.Source.At the same time, the "content source event" may be delivered, triggering also the read of
Chunks from theContent.Source.The solution was to delay the call of the application BiFunction at the "content source event". In this way, there is only one trigger to read
Chunks from theContent.Source: when the application demands on thePublisher<T>returned to the application.