-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servlet 6.1 tck cookie test errors #11934
Comments
21 tasks
gregw
added a commit
that referenced
this issue
Jun 20, 2024
Added compliance mode MAINTAIN_QUOTES to keep the quotes as part of the cookie value. Added mode RFC6265_QUOTED that includes this violation
gregw
added a commit
that referenced
this issue
Jun 20, 2024
Never send a zero valued max-age parameter
gregw
added a commit
that referenced
this issue
Jun 20, 2024
Partitioned is set if any attribute that is not "false" is set.
gregw
added a commit
that referenced
this issue
Jun 20, 2024
Partitioned is set if any attribute that is not "false" is set. Avoid equal sign for empty valued attributes
gregw
added a commit
that referenced
this issue
Jun 20, 2024
Added compliance mode MAINTAIN_QUOTES to keep the quotes as part of the cookie value. Added mode RFC6265_QUOTED that includes this violation
gregw
added a commit
that referenced
this issue
Jun 20, 2024
Never send a zero valued max-age parameter
gregw
added a commit
that referenced
this issue
Jun 20, 2024
Partitioned is set if any attribute that is not "false" is set.
gregw
added a commit
that referenced
this issue
Jun 20, 2024
Partitioned is set if any attribute that is not "false" is set. Avoid equal sign for empty valued attributes
gregw
added a commit
that referenced
this issue
Jun 23, 2024
* Fix #11934 Servlet 6.1 Cookies * Added compliance mode MAINTAIN_QUOTES to keep the quotes as part of the cookie value. Added mode RFC6265_QUOTED that includes this violation * Never send a zero valued max-age parameter * Partitioned is set if any attribute that is not "false" is set. * Avoid equal sign for empty valued attributes * Pushed responses delete max-age==0 cookies
Fixed via #11936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
jetty-12.1.x
Failing Test
servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest
This test sends a cookie from the client to the server that is constructed like so:
The test expects that the value of the
name1
cookie is interpreted by the server as"value1"
, ie that double quotes are retained.Failing Test
servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.setMaxAgeZeroTest
The test creates a
Cookie
and callssetMaxAge(0)
on it. The test expects that theMax-Age
field will be missing on theSet-Cookie
response header, but we are sendingMax-Age=0
. Looking at RFC6265 it does seem thatMax-Age
should never be0
:Failing Test
servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.setPartitionedTest
The test creates a
Cookie
and callssetAttribute("Partitioned", "")
The test expects that aSet-Cookie
will containPartitioned
, however, we only sendPartitioned
iffsetAttribute("Partitioned", "true")
was called.The text was updated successfully, but these errors were encountered: