Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servlet 61 cookie fixes #11936

Merged
merged 9 commits into from
Jun 23, 2024
Merged

Servlet 61 cookie fixes #11936

merged 9 commits into from
Jun 23, 2024

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Jun 20, 2024

Fix #11934 Servlet 6.1 cookies:

  • don't send a max-age=0
  • treat any non null non "false" attribute value as a true
  • don't send = for empty cookie attribute values
  • added compliance mode MAINTAIN_QUOTES to keep the quotes as part of the cookie value. Added mode RFC6265_QUOTED that includes this violation

gregw added 4 commits June 20, 2024 19:02
@gregw
Fix #11934 Servlet 6.1 Cookies
6c41fff 
Added compliance mode MAINTAIN_QUOTES to keep the quotes as part of the cookie value.  Added mode RFC6265_QUOTED that includes this violation
@gregw
Fix #11934 Servlet 6.1 Cookies
acced9f 
Never send a zero valued max-age parameter
@gregw
Fix #11934 Servlet 6.1 Cookies
d96d4bc 
Partitioned is set if any attribute that is not "false" is set.
@gregw
Fix #11934 Servlet 6.1 Cookies
120ae21 
Partitioned is set if any attribute that is not "false" is set.
Avoid equal sign for empty valued attributes
@gregw gregw requested review from joakime and janbartel June 20, 2024 09:08
@gregw gregw added Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Jun 20, 2024
janbartel
janbartel approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, but overall +1.

jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/RFC6265CookieParser.java Outdated Show resolved Hide resolved
...-ee11/jetty-ee11-servlet/src/main/java/org/eclipse/jetty/ee11/servlet/ServletApiRequest.java Show resolved Hide resolved
@gregw gregw requested a review from janbartel June 21, 2024 01:24
joakime
joakime approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to ConnectionMetaData.isPushSupported() deprecation seems odd, but ultimately harmless.

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ConnectionMetaData.java Show resolved Hide resolved
@gregw gregw merged commit 1e241d8 into jetty-12.1.x Jun 23, 2024
10 checks passed
@gregw gregw deleted the fix/jetty-12.1.x/11934/Servlet61Cookies branch June 23, 2024 03:13
@janbartel janbartel mentioned this pull request Jun 25, 2024
Closed
21 tasks
@janbartel janbartel mentioned this pull request Jul 5, 2024
Closed
@olamy olamy mentioned this pull request Sep 29, 2024
Merged
@olamy olamy mentioned this pull request Oct 17, 2024
Merged
@olamy olamy mentioned this pull request Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@janbartel janbartel janbartel approved these changes

Assignees
No one assigned
Labels
Specification For all industry Specifications (IETF / Servlet / etc) TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
Jetty 12.1.0
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregw @joakime @janbartel